check the logger for trace and the options for withTrace#304
Open
danReynolds wants to merge 1 commit intoLogRocket:masterfrom
NerdWallet:master
Open
check the logger for trace and the options for withTrace#304danReynolds wants to merge 1 commit intoLogRocket:masterfrom NerdWallet:master
danReynolds wants to merge 1 commit intoLogRocket:masterfrom
NerdWallet:master
Conversation
danReynolds
changed the title
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=====================================
Coverage 82% 82%
=====================================
Files 5 5
Lines 150 150
=====================================
Hits 123 123
Misses 27 27
Continue to review full report at Codecov.
|
|
Can someone review this? it's pretty useful. |
|
bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue with: #205
In the PR feedback it was recommended to make a
withTraceoption for the config, but instead it was used to check the logger object.What we want to happen is to have a
withTraceoption checked off the config as well as atraceproperty checked off of the logger object to make sure it supports trace.